Use separate misc
table for the KnowledgeDB
#7413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deadlocks that happen with mutual updates from:
KnowledgeRulesProcessor
(write attempt toKnowledgeDB
andMetadataDB
in theprocess_batch
function)MDS
(write attempt toKnowledgeDB
andMetadataDB
in the constructor ofTorrentMetadata
)This situation arises when two factors coincide:
Metadata Store
uses a different thread to perform operations with the DB).This PR eliminates the write attempts from
KnowledgeRulesProcessor
toMetadataDB
by beginning to utilize a separatemisc
table.Please note that this PR does not entirely solve the deadlock problem. A comprehensive solution will involve one of the following:
KnowledgeDB
andMetadataDB
into a single database.notifications.new_torrent_metadata_created
event.Refs: