Add CONTENT_ITEM relation
#7445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
fix/content_item
branch
2 times, most recently
from
4ab2c6f
to
eeeb659
Compare
drew2a
commented
May 30, 2023
| @@ -1,2 +1,2 @@ | |||
| MIN_RESOURCE_LENGTH = 3 | |||
| MIN_RESOURCE_LENGTH = 2 | |||
There was a problem hiding this comment.
This change is necessary for the language statements transfer (nl, ru, en)
drew2a
commented
May 30, 2023
| @@ -65,24 +65,21 @@ async def update_knowledge_entries(self, request): | |||
| return error_response | |||
|
|
|||
| # Validate whether the size of the tag is within the allowed range and filter out duplicate tags. | |||
| tags = set() | |||
There was a problem hiding this comment.
This set() is unnecessary here because statements anyway will be converted to sets later.
kozlovsky
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits two relations:
TITLEandCONTENT_ITEMas they will be used for different purposes.CONTENT_ITEMto combine items into groups (Tag based content discovery and crowdsourcing #6214)TITLEto store the original title of the torrent after the big migration (The big migration: from the Channels to the Knowledge Graph #7398)Also, it fixes inconsistency with statement size limitations.