100x speedup of EdgeWalk.take_step() by caching results of GigaChannelCommunity.guess_address() #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
kozlovsky
force-pushed
the
fix/netifaces_cache
branch
from
a0a117a
to
3efd12e
Compare
|
Since I was requested for review, I have one question about this implementation: If the symptoms of #7427 are only caused by the |
…to GigaChannelCommunity.guess_address()
kozlovsky
force-pushed
the
fix/netifaces_cache
branch
from
3efd12e
to
ea60015
Compare
|
@qstokkink I reimplemented it as a method of |
kozlovsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7427.
This PR monkey-patches the
Community.guess_addressmethod to add 5-second caching of its results.It allows to speed up
EdgeWalk.take_step()(that sometimes blocks the asyncio loop) by 100 times from 3 seconds to 0.03 seconds.The next version of IPv8 is expected to include proper caching, so this patch can be removed after upgrading to a version of IPv8 that natively implements caching.