Increase the size of log files and the number of log file backups #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Jun 1, 2023
…the number of log backups from 1 to 2
kozlovsky
force-pushed
the
increase_log_size
branch
from
64bf940
to
faa63f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current size of log files is 100 kilobytes per file, with one backup file for each log file. It is too small if we are trying to find the error details in log files, as the file got deleted quickly.
In this PR, I slightly increase the size of log files: from 100 kilobytes to 1 megabyte and the number of log file backups from 1 to 2.
As a result, we should have 6 log files (
tribler-gui-info.log, 'tribler-gui-error.log',tribler-core-info.log, andtribler-core-error.log) of 1 megabyte each and two backups for each file, 12 megabytes in total (still not too much).