Fixes #7406 UnicodeDecodeError in on_tracker_error_alert #7468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7406 by moving the
self._logger.error
call into the try/except block. It also replacesself._logger.exception
withself._logger.warning
in case of an error, as the error's origin is known and handled adequately by the workaround.Initially, in the discussion of #7410, I suggested adding a
safe_repr
function to wrapalert
with it, but according to arvidn/libtorrent#143,on_tracker_error_alert
is the only place where the error can happen, so it is not necessary to implement a reusable function forsafe_alert
, as otheron_xyz_alert
handlers do not require a fix.