Use TestError instead of AssertionError in test to avoid confusion #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
kozlovsky
changed the title
kozlovsky
force-pushed
the
fix/raising_assertion_error_in_test
branch
2 times, most recently
from
2df2d27
to
2920e0c
Compare
drew2a
approved these changes
Jun 26, 2023
|
Related to #7495 |
kozlovsky
force-pushed
the
fix/raising_assertion_error_in_test
branch
from
2920e0c
to
bd769f1
Compare
kozlovsky
force-pushed
the
fix/raising_assertion_error_in_test
branch
from
bd769f1
to
179d5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests (of the Core test suite) deliberately raise an AssertionError and expect it to be in
error_handler._handled_exceptions. It is better to raise a specificTestErrorinstead of a genericAsserionErrornot to be confused about whether the error was planned or unexpected. In this PR, I changeAssertionErrortoTestErrorto avoid possible confusion.The reason I want to fix it is that I had observed seen some strange cases when the string
"AssertionError"was inerror_handler._handled_exceptionswhile it was expected to be empty (unfortunately can't provide an example right now), and I want to eliminate possible cases of it.