Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendezvous Certificates #7517

Closed
wants to merge 9 commits into from

Address requested changes and comments

6dc9d4c
Select commit
Loading
Failed to load commit list.
Closed

Rendezvous Certificates #7517

Address requested changes and comments
6dc9d4c
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codacy Production / Codacy Static Code Analysis required action Aug 16, 2023 in 0s

10 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 10
           

Complexity increasing per file
==============================
- src/tribler/core/components/popularity/rendezvous/tests/test_rendezvous_cache.py  2
- src/tribler/core/components/popularity/rendezvous/rendezvous.py  1
- src/tribler/core/components/popularity/rendezvous/db/database.py  4
- src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py  5
- src/tribler/core/components/popularity/rendezvous/db/orm_bindings/misc.py  1
- src/tribler/core/components/popularity/rendezvous/db/orm_bindings/certificate.py  1
- src/tribler/core/components/popularity/popularity_component.py  1
- src/tribler/core/components/popularity/community/popularity_community.py  3
         

Clones added
============
- src/tribler/core/components/popularity/rendezvous/db/database.py  1
- src/tribler/core/components/popularity/community/tests/test_popularity_community.py  2

See the complete overview on Codacy

Annotations

Check warning on line 290 in src/tribler/core/components/popularity/community/tests/test_popularity_community.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/community/tests/test_popularity_community.py#L290 

Access to a protected member _create_rendezvous_response of a client class

Check warning on line 306 in src/tribler/core/components/popularity/community/tests/test_popularity_community.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/community/tests/test_popularity_community.py#L306 

Access to a protected member _create_rendezvous_response of a client class

Check warning on line 1 in src/tribler/core/components/popularity/rendezvous/db/orm_bindings/certificate.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/db/orm_bindings/certificate.py#L1 

Unused db_session imported from pony.orm

Check warning on line 1 in src/tribler/core/components/popularity/rendezvous/rendezvous.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous.py#L1 

Unused import dataclasses

Check warning on line 3 in src/tribler/core/components/popularity/rendezvous/rendezvous.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous.py#L3 

Unused fields imported from dataclasses

Check warning on line 2 in src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py#L2 

Unused defaultdict imported from collections

Check warning on line 5 in src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py#L5 

Unused Peer imported from ipv8.peer

Check warning on line 33 in src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py#L33 

Unused variable 'peer_challenge'

Check warning on line 36 in src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/rendezvous_cache.py#L36 

Expression "[self._cache.pop(peer) for peer in to_remove]" is assigned to nothing

Check warning on line 15 in src/tribler/core/components/popularity/rendezvous/tests/test_rendezvous_cache.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/tribler/core/components/popularity/rendezvous/tests/test_rendezvous_cache.py#L15 

The u prefix for strings is no longer necessary in Python >=3.0
View more details on Codacy Production