CoreExceptionHandler should ignore all occurrences of ConnectionResetError #7566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team,
drew2a and
xoriole
and removed request for
a team and
drew2a
xoriole
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7556. ConnectionResetError means that a client dropped a connection to the AIOHTTP server before the response was sent back. On the server side, it is not an error and should be ignored.
Before this fix, only ConnectionResetError with error code 10054 is ignored. When aiohttp raises ConnectionResetError, it does not specify any error code, so all instances of ConnectionResetError should be ignored, disregarding the error code.
Previously there were two groups of errors ignored by SentryReporter:
IGNORED_ERRORS_BY_CODEandIGNORED_ERRORS_BY_REGEX. The PR adds a third group,IGNORED_ERRORS_BY_CLASS.