Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a title to knowledge processing #7595

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Sep 12, 2023

This PR is related to issue #7398 and serves as the first step in the migration process.

After the implementation of this PR, all incoming titles will be stored in knowledge.db. Additionally, all existing titles will be moved to knowledge.db in the background.

In addition, this PR introduces estimated time calculation to the KnowledgeRulesProcessor.

@drew2a drew2a force-pushed the feature/add_torrent_title_to_processor branch from 8d544ad to 9a55298 Compare September 12, 2023 13:32
@drew2a drew2a marked this pull request as ready for review September 13, 2023 06:56
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team September 13, 2023 06:56
Copy link
Contributor

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Co-authored-by: Alexander Kozlovsky <alexander.kozlovsky@gmail.com>
@drew2a drew2a force-pushed the feature/add_torrent_title_to_processor branch from a4c8696 to 921e8db Compare September 13, 2023 12:55
@drew2a drew2a merged commit 6770014 into Tribler:main Sep 13, 2023
16 checks passed
@drew2a drew2a deleted the feature/add_torrent_title_to_processor branch September 13, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants