Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove channels from the Application Tester #7742

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Remove channels from the Application Tester #7742

merged 7 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. Refactor the Application Tester 

    - Remove import statement for `pathlib.Path`
- Remove unused imports for `explore_channel_action`, `manage_channel_action`, `scroll_discovered_action`, and `subscribe_unsubscribe_action`

This commit refactors the main script by removing unnecessary imports and unused code. It removes the import statement for `pathlib.Path` as it is not used in the script. Additionally, it removes the unused imports for `explore_channel_action`, `manage_channel_action`, `scroll_discovered_action`, and `subscribe_unsubscribe_action`. These changes improve the readability and maintainability of the codebase.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d3d0c19 View commit details
    Browse the repository at this point in the history

  2. Refactor download-related code and remove unused methods 

    - Remove unused methods `set_channel_download`, `get_channel_download`, `set_add_to_channel`, and `get_add_to_channel` from `DownloadConfig` class
- Refactor code in `DownloadManager` class to remove the usage of the removed methods
- Update logic in `DownloadsEndpoint` class to skip hidden downloads without checking for channel downloads
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b89ca5b View commit details
    Browse the repository at this point in the history

  3. Refactor: Update logger formatting and colors 

    This commit updates the formatting and colors of the logger in the `logger.py` file. The log colors for 'DEBUG' and 'INFO' levels have been set to white. This improves the readability and visual appeal of log messages.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    7c5975a View commit details
    Browse the repository at this point in the history

  4. Refactor page navigation and download progress update 

    - Removed unnecessary buttons from the page navigation in Tribler's application tester.
- Removed unnecessary code for updating download progress information for ChannelTorrents in the DownloadsPage widget.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    8158747 View commit details
    Browse the repository at this point in the history

  5. Refactor action selection logic in executor.py 

    The code changes refactor the action selection logic in the `perform_random_action` method of `executor.py`. Instead of using a series of if-else statements, a dictionary called `actions` is introduced to map action names to their corresponding classes or lambda functions. This improves readability and maintainability of the code.

The commit message summarizes the significant changes made to improve the action selection logic in executor.py.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ab7bed7 View commit details
    Browse the repository at this point in the history

  6. Add test for torrent_finished notification 

    This commit adds a new test case to ensure that the `torrent_finished` notification is called when the torrent finishes. The test verifies that the notification is correctly called with the expected parameters, including the infohash, name, and hidden status of the download.

The added test case helps ensure that the `on_torrent_finished_alert` method behaves as expected and triggers the appropriate notification when a torrent finishes downloading.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ebf929d View commit details
    Browse the repository at this point in the history

  7. Refactor action instantiation in executor.py 

    The code changes refactor the instantiation of actions in the `perform_random_action` method of `executor.py`. Instead of using lambda functions, the actions are now instantiated directly. This improves code readability and maintainability.
    @drew2a
    drew2a committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6d55521 View commit details
    Browse the repository at this point in the history