Update signing script for macos build #8063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix signing dmg Add spctl assement at the end of macos signing to check notarization
drew2a
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the MacOS (app and installer dmg) build signing.
The signing part is extracted to separate scripts from the build script. Further, app and dmg signing are separated.
The build is fully running on mac_mini on Jenkins which removes the dependency on external dependent machines previously used for signing.
Additionally, there is some refactoring done on the build script, extracting the environment variables into a separate file
env.sh.Here is a working build from this PR:
https://jenkins.tribler.org/job/Tribler/job/Build/job/Build-macOS/174/