Tweak to SETDBR to fix issues with PRINT and PUTS #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked the altered SETDBR macro.
Figured out what the error was in SETDBR... the bank# operator (`) in the parameter was grabbing the multiplication in the macro... basically macros aren't hygenic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the SETDBR macro that cause it to fail if the data bank was not 0. The macro expanded to:
But, the bank operator has a low precedence, and so the PEA was calculating the wrong value... like so:
This fix protects multiplication by wrapping the parameter in parentheses.