Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken integration tests #586

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gbmeuk
Copy link

@gbmeuk gbmeuk commented Nov 4, 2019

tests are failing because ps is missing from the node base Docker image

Thanks for contributing to ContainerPilot! Please include with your pull request:

  • A description of what you did for the changelog
    fix broken integration tests
  • An explanation of why ContainerPilot needs this change
    so changes are properly tested
  • How to verify that it works (most PRs need tests!)
    tests which were previously failing due to ps missing, no longer fails
  • A link to the GitHub issue that it addresses

If you're contributing a new feature, it's usually better to open an issue to discuss the feature rather than open a pull request unless the feature is trivial.

tests are failing because ps is missing from the node base Docker image
@gbmeuk gbmeuk changed the title add procps as package for test fixtures Fix broken integration tests Nov 4, 2019
@teutat3s teutat3s mentioned this pull request Apr 14, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant