Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantaClient#listObjects leaks a MantaDirectoryListingIterator when the iterator is empty #400

Closed
tjcelaya opened this issue Jan 10, 2018 · 0 comments
Labels

Comments

@tjcelaya
Copy link
Contributor

tjcelaya commented Jan 10, 2018

Following some investigation from #398 led to the discovery that some directory listing operations also leak connections. Currently disentangling the BufferedReader close from the CloseableHttpResponse close to see where exactly this is occurring.

This seems to be more relevant to the parallelism of the findForkJoinPool when setting max_connections = 1 and is not actually a connection leak. Renamed.

The issue was in Mantaclient#listObjects intentionally returning an empty stream but forgetting to close the iterator used to determine the stream should be empty.

@tjcelaya tjcelaya changed the title MantaDirectoryListingIterator intermittently leaking connections Revisit findForkJoinPool behavior when max_connections = 1 Jan 10, 2018
@tjcelaya tjcelaya changed the title Revisit findForkJoinPool behavior when max_connections = 1 MantaClient#listObjects leaks a MantaDirectoryListingIterator when the iterator is empty Jan 11, 2018
tjcelaya added a commit to tjcelaya/java-manta that referenced this issue Jan 11, 2018
@tjcelaya tjcelaya added bug and removed enhancement labels Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant