Added SDK version to all contexted exceptions by default #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcelaya
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
LGTM!
Checked all the root exception classes that we define and made sure they were all covered.
Unfortunate that it needs to be added to each individual constructor of MantaIOException but that doesn't seem to be avoidable. If we start adding more default context values like these I'd want to pull them out into something like addDefaultContextValues() so it can be updated similarly to the initializers in other classes but that's not relevant yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users submit bugs with stack traces against the SDK, there is no way to know what version of the SDK that they are using by a single glance. This change embeds the SDK version in every Manta exception class that implements
ExceptionContext.