Remove redundant integration test runs #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in addition to actually using the encryptionCipher parameter
… triggering network requests
|
Reminder: On the last run integration tests had 64% instruction coverage and 39% branch coverage. After this lands those numbers should stay the same. |
cburroughs
approved these changes
Oct 30, 2017
|
For the dry-run aspect of this PR see testng-team/testng#1503. Updating to TestNG version 6.14 and using the |
indianwhocodes
force-pushed
the
master
branch
from
a997bcb
to
b2fb2cd
Compare
indianwhocodes
approved these changes
Apr 9, 2019
indianwhocodes
suggested changes
Apr 10, 2019
| @Parameters({"usingEncryption"}) | ||
| public void beforeClass(@org.testng.annotations.Optional Boolean usingEncryption) throws IOException { | ||
| @Parameters({"encryptionCipher"}) | ||
| public EncryptedServerSideMultipartManagerSerializationIT(final @Optional String encryptionCipher) throws IOException { |
There was a problem hiding this comment.
A compilation-error will be generated here since this integration-test will mandatorily require invocation of the TestNG parameter encryptionCipher
indianwhocodes
added
duplicate
and removed
enhancement
good first issue
test-bug
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #336 and adds a
it.dryrunproperty that can be used to list the tests that would run with their respective TestNG params. Unfortunately it looks like TestNG doesn't completely support filtering a test suite by groups so we need to be more explicit about suite definition.Output of
it.dryrunusing currenttestng-it.xml(with some fixes to allow it to be used withTestListingInterceptor:Count of test cases that would run using new
testng-it.xml:Lists for both are here. Note that the
dry-run-afterlist is slightly inaccurate since it shows different values forencryptionCipher. Other changes in this branch include usingencryptionCipherso a dry-run listing ofmasterwould showAES128/CBC/PKCS5Paddingfor all non-null ciphers in that list.Changes
usingEncryption(boolean) to justencryptionCipher(string). omission (null) disables encryptionIntegrationTestConfigContextwhich handles the above@BeforeClasswith@Parametersto test constructors with just@Parameters. WheneverSkipExceptionwas thrown orputDirectorywas called in a test which needed@Parametersa minimal method was created for@BeforeClass. The goal here was to make it safe to instantiate test classes without incurring side-effects.MantaClientDirectoriesIT)<packages>to<classes>and target specific classes. I was going to use test groups for this but it seems like TestNG has trouble with mixing group filters with packages/classes (e.g. the comment intestng-it.xmlabout how we can't use<groups><run><exclude>multipart</exclude></run></group>it.dryrunwhich can be used by the new interceptor. When this system property is truthy as defined byBooleanUtils#toBooleanObject, i.e. the following are all true:y,Y,t,T,on,ON,yes,YES,true,TRUEand all the mixed-case versions thereofTestListingInterceptorwhich can be used to collect suite definitions and disable actually running tests in the eventit.dryrunis truthy