Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release branch #503

Merged
merged 18 commits into from
Apr 8, 2019
Merged

Release branch #503

merged 18 commits into from
Apr 8, 2019

Conversation

indianwhocodes
Copy link
Contributor

Release branch that has been tracking the changes that were supposed to be made after release of java-manta-sdk-3.4.0

indianwhocodes and others added 9 commits March 12, 2019 19:58
@indianwhocodes
Fixing Issue#479 (#500)
6d39345
@indianwhocodes
Follow-Up After Investigating Fixing#479 (#499)
43b2901
@indianwhocodes
String Literals Refactored Commit
65cdc7c
@indianwhocodes
Equals() Changes Commit
049c052
@indianwhocodes
Copyright Headers Commit
5588217
@indianwhocodes
Document MetricReporterSupplier Class, Additional Changes (#473)
3680d6f 
* Remove invalid comments

* Added javadoc, Changed Exception Signature

* Remove Unused Exception, WhiteSpace-Consistency

* Added Author name

* Added source reference for Metrics
@indianwhocodes
Fixing Issue#480 (#496)
9bf9ef4 
* Fixing Issue#480

* Elijah's Feedback

* JavaDoc description for skipping test

* Removed @test annotation, waiting on #474 to be merged

* Final Changes

* Refactoring, Add @test dependencies
@indianwhocodes
Developer's Guide Added (#495)
0c74ca9 
More Feedback from Elijah, Carol
Fix 470 and Update MantaErrorCode Enum Values
da9c9f0 
Remove Duplicates with same rest codes

Remove Error Codes tagged Duplicated && Deprecated

Elijah's Feedback.
@indianwhocodes indianwhocodes self-assigned this Mar 25, 2019
@indianwhocodes indianwhocodes mentioned this pull request Apr 8, 2019
Merged
@indianwhocodes
Copy link
Contributor Author

Awaiting Review ?

@indianwhocodes
Copy link
Contributor Author

This branch will be squashed and merged.

@indianwhocodes indianwhocodes merged commit 81356b0 into master Apr 8, 2019
@indianwhocodes indianwhocodes deleted the release-branch branch April 11, 2019 18:46
@indianwhocodes indianwhocodes restored the release-branch branch April 11, 2019 22:22
@indianwhocodes indianwhocodes deleted the release-branch branch April 16, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees

@indianwhocodes indianwhocodes

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indianwhocodes @dekobon