-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mdb_v8 to support V8 4.4.x, and possibly 4.5.x #23
Labels
Comments
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 4, 2015
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 4, 2015
misterdjules
added a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 4, 2015
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
added a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
added a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
added a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 8, 2015
misterdjules
added a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Hardcode handling of V8_SCOPEINFO_IDX_FIRST_VARS' fallback value for different versions of V8. Do not rely on V8's metadata for getting V8_SCOPEINFO_OFFSET_STACK_LOCALS' value, use V8_CONSTANT_FALLBACK instead.
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Hardcode handling of V8_SCOPEINFO_IDX_FIRST_VARS' fallback value for different versions of V8. Do not rely on V8's metadata for getting V8_SCOPEINFO_OFFSET_STACK_LOCALS' value, use V8_CONSTANT_FALLBACK instead.
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Hardcode handling of V8_SCOPEINFO_IDX_FIRST_VARS' fallback value for different versions of V8. Do not rely on V8's metadata for getting V8_SCOPEINFO_OFFSET_STACK_LOCALS' value, use V8_CONSTANT_FALLBACK instead.
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Hardcode handling of V8_SCOPEINFO_IDX_FIRST_VARS' fallback value for different versions of V8. Do not rely on V8's metadata for getting V8_SCOPEINFO_OFFSET_STACK_LOCALS' value, use V8_CONSTANT_FALLBACK instead.
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Hardcode handling of V8_SCOPEINFO_IDX_FIRST_VARS' fallback value for different versions of V8. Do not rely on V8's metadata for getting V8_SCOPEINFO_OFFSET_STACK_LOCALS' value, use V8_CONSTANT_FALLBACK instead.
misterdjules
pushed a commit
to misterdjules/mdb_v8
that referenced
this issue
Sep 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nodejs/node upgraded V8 to 4.4.63.30 in the 4.x branch, and to V8 4.5.x in the master branch.
mdb_v8 does not support these new V8 versions correctly:
I have a set of changes ready that fix these issues, and so far all tests pass for 64bits and 32bits builds. I will submit a PR with these changes shortly.
It's not clear to me yet with which V8 version node 4.x LTS will ship, even though it seems likely that it'll ship with V8 4.5.x. From my tests, the fixes needed to make mdb_v8 work with V8 4.4.x are sufficient to make it work with V8 4.5.x (all tests pass).
The text was updated successfully, but these errors were encountered: