Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-fast should support fixed buckets and artedi v2 #21

Open
joshwilsdon opened this issue Nov 16, 2018 · 0 comments
Open

node-fast should support fixed buckets and artedi v2 #21

joshwilsdon opened this issue Nov 16, 2018 · 0 comments

Comments

@joshwilsdon
Copy link
Contributor

This mirrors internal ticket TRITON-923.

With TritonDataCenter/node-artedi#17 we've resolved some problems with histogram buckets by making the buckets fixed rather than dynamic. node-fast needs to be updated so that it uses fixed buckets when passed an artedi v2 collector so that its histograms don't run into the problems described in that ticket.
joyent-automation pushed a commit that referenced this issue Nov 16, 2018
@joshwilsdon
#21 node-fast should support fixed buckets and artedi v2
cb09be8 
Reviewed by: Kody A Kantor <kody@kkantor.com>
Approved by: Kody A Kantor <kody@kkantor.com>
@kellymclaughlin kellymclaughlin mentioned this issue Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshwilsdon