-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump min node version to 0.10 and add CI testing #92
Comments
trentm
changed the title
Node engine support
bump min node version to 0.10 and add CI testing
Nov 5, 2019
trentm
added a commit
that referenced
this issue
Nov 5, 2019
trentm
added a commit
that referenced
this issue
Nov 5, 2019
This was referenced Feb 18, 2022
Open
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran into an issue today on my lab machine when trying to run the latest version of
buckets-mdplacement
(a freshly made image).The shorthand property setting is what caused the issue:
Judging by https://node.green/#ES2015-syntax-object-literal-extensions-shorthand-properties it looks like this shorthand syntax was added in node 4.9, and doesn't exist in 0.8 or 0.10.
This specific issue will be fixed in v1.3.1 of this module, but going forward there are some things we may want to consider. As @trentm mentioned in an email:
Though bumping the engine would have to go to at least 4.9 if what I mentioned above is correct. Ensuring we run
make check
on our changes in this repo should help identify this issue happening in the future as well.The text was updated successfully, but these errors were encountered: