Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecc-jsbn dependency #3

Closed
wants to merge 1 commit into from
Closed

Conversation

poke
Copy link
Contributor

@poke poke commented Apr 22, 2016

This removes the dependency on ecc-jsbn 0.0.1 which unfortunately depends on a Git version of jsbn. That fact broke our build today (since we don’t have Git on our build server).

The upgrade to ecc-jsbn 0.1.1 should hopefully not cause any problems for this package.

It was already already being used in earlier versions since the old version range (before 7c4fc62) was >=0.0.1 <1.0.0 which included 0.1.1 while ^0.0.1 does not.

@codecov-io
Copy link

Current coverage is 88.32%

Merging #3 into master will not affect coverage as of 30ca73a

@@            master      #3   diff @@
======================================
  Files           18      18       
  Stmts         1978    1978       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           1747    1747       
  Partial          0       0       
  Missed         231     231       

Review entire Coverage Diff as of 30ca73a

Powered by Codecov. Updated on successful CI builds.

@amacneil
Copy link

👍 This also broke my build, should be merged asap.

@kylinwater
Copy link

+1 our build is broken too.
And we started to realize using npm install to restore packages from official registry might not be a good idea.

arekinath pushed a commit that referenced this pull request Apr 25, 2016
@arekinath
Copy link
Contributor

Thanks for spotting this one, @poke. I've merged it as 763f4a6 and released 1.8.2 to npm. Sorry for the noise everyone, this was a bit of a silly mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants