Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create footer component #40

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Create footer component #40

merged 9 commits into from
Jan 30, 2025

Conversation

EdwardLinS
Copy link
Contributor

Tracking Info

Resolves #32

Changes

  • Created the page footer component for the different screen sizes
    • Desktop/tablet layout
    • Mobile layout

Testing

  • Tried various screen sizes to test responsiveness and visibility of elements

Confirmation of Change

Desktop/Tablet View
image

Mobile View
image

@EdwardLinS EdwardLinS linked an issue Jan 29, 2025 that may be closed by this pull request
[COMPONENT] Page Footer #32
Closed
@EdwardLinS EdwardLinS marked this pull request as ready for review January 29, 2025 08:00
@EdwardLinS EdwardLinS requested a review from mraysu as a code owner January 29, 2025 08:00
@mraysu
Copy link
Collaborator

mraysu commented Jan 29, 2025

Component looks great! Because we want this to render on most of our forward-facing pages, can you add the footer component to the bottom of the root layout?

@EdwardLinS
Copy link
Contributor Author

Component looks great! Because we want this to render on most of our forward-facing pages, can you add the footer component to the bottom of the root layout?

Just added!

@mraysu mraysu requested a review from westonz7042 January 30, 2025 01:30
mraysu
mraysu approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@mraysu mraysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎉

@westonz7042
Copy link
Contributor

lgtm!

@EdwardLinS EdwardLinS merged commit e25466c into main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonz7042 westonz7042 westonz7042 approved these changes

@mraysu mraysu mraysu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[COMPONENT] Page Footer
3 participants
@EdwardLinS @mraysu @westonz7042