implement DEEP-ALI #190
Merged
implement DEEP-ALI #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszepieniec
approved these changes
Apr 20, 2023
| @@ -182,7 +186,8 @@ impl Stark { | |||
| prof_start!(maybe_profiler, "ext tables"); | |||
| prof_start!(maybe_profiler, "LDE"); | |||
| master_ext_table.randomize_trace(); | |||
| let fri_domain_ext_master_table = master_ext_table.to_fri_domain_table(); | |||
| let (fri_domain_ext_master_table, ext_interpolation_polys) = | |||
| master_ext_table.to_fri_domain_table(); | |||
There was a problem hiding this comment.
I don't think we need to keep track of the polynomials if we have barycentric evaluation. File under: optimizable-if-bottleneck.
triton-vm/src/stark.rs
Outdated
| prof_start!(maybe_profiler, "out-of-domain rows"); | ||
| let trace_domain_generator = derive_domain_generator(padded_height.value()); | ||
| let out_of_domain_value_curr_row = proof_stream.sample_scalars(1)[0]; | ||
| let out_of_domain_value_next_row = trace_domain_generator * out_of_domain_value_curr_row; |
There was a problem hiding this comment.
I would suggest to use "point" instead of "value" because "value" implies (to my ears at least) that it's the output of some evaluation. Here's it's the opposite: it's the input!
| &base_and_ext_codeword, | ||
| quotient_domain, | ||
| out_of_domain_value_next_row, | ||
| out_of_domain_next_row_base_and_ext_element, | ||
| ); |
There was a problem hiding this comment.
I would prefer to avoid overloading the term "quotient" because then there will be quotient quotients.
triton-vm/src/stark.rs
Outdated
| prof_start!(maybe_profiler, "out-of-domain quotient element"); | ||
| prof_start!(maybe_profiler, "zerofiers"); | ||
| let one = BFieldElement::one(); | ||
| let trace_domain_generator = derive_domain_generator(padded_height as u64); |
There was a problem hiding this comment.
let trace_domain_generator = derive_domain_generator(padded_height as u64);
Did I read that line twice?
| .par_iter() | ||
| .map(StarkHasher::hash) | ||
| .map(|&x| x.into()) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
I'm not sure what these three lines are supposed to do.
let revealed_quotient_digests = revealed_quotient_elements
.par_iter()
.map(|&x| x.into())
Maybe add an explicit type to clarify?
There was a problem hiding this comment.
I have a added the following comment instead:
// Interpret the leaves, which are XFieldElements, as Digests, without hashing.
Does that clarify the operation sufficiently?
- don't hash codewords, interpret `XFieldElement`s as `Digest`s directly - don't return `Result<…>` where only `Ok(…)` is ever used - `fri.verify()` checks first codeword's Merkle root implicitly - `fri.verify()` returns revealed indices and elements on success - remove now-obsolete `FriValidationError` variant - improve comments & code readability
Use the codeword and the indices from the first round of FRI instead, which is identical anyway.
Co-authored-by: Alexander Lemmens <alexanderlemmens@hotmail.com>
Also some more variable name consistency.
jan-ferdinand
added a commit
that referenced
this pull request
Apr 24, 2023
- do DEEP-ALI instead of plain ALI in the zk-STARK (#190) (9606441) - add convenience functions for using Triton VM (0dab32a) (dda05e4) - improve Triton profiler (#191) (7edd1a2) - add profiling of categories - introduce more weights for relative runtime costs - print relative time for all tasks and sub-tasks - make method `debug` more powerful (ab49df7) - add optional argument: initial state - add optional argument: number of execution steps - add construction of AET (witness generation) to profiling (c6e7b1e) - use `cfg(debug_assertions)`, not environment variable (b0052f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.