Break cyclic build dependency #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: ignore
changelog: ignore
changelog: ignore
changelog: ignore
Use a build script to generate the required constraint code. This breaks the circular dependency of Triton VM. changelog: ignore
changelog: ignore
changelog: ignore
jan-ferdinand
force-pushed
the
circuit_builder_refactor
branch
from
d83b806 to
098103e
Compare
changelog: ignore
The Makefile simplified building Triton VM despite the cyclic dependency in its build process. Now, the cyclic build dependency is broken. Cargo is the recommended build tool for Triton VM.
changelog: ignore
jan-ferdinand
force-pushed
the
circuit_builder_refactor
branch
from
3da25ea to
278244a
Compare
Over the years, the terminology of “main” and “auxiliary” tables has become dominant over our terminology of “base” and “extension” tables. changelog: ignore
changelog: ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdto each crate