Skip to content

Commit

Permalink
test: use platform-based timeout for reliability
Browse files Browse the repository at this point in the history
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: nodejs#4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
  • Loading branch information
Trott committed Nov 26, 2015
1 parent 459b106 commit 20acc60
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/parallel/test-http-client-timeout-with-data.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var http = require('http');
const common = require('../common');
const assert = require('assert');
const http = require('http');

var ntimeouts = 0;
var nchunks = 0;
Expand All @@ -11,21 +11,21 @@ process.on('exit', function() {
assert.equal(nchunks, 2);
});

var options = {
const options = {
method: 'GET',
port: common.PORT,
host: '127.0.0.1',
path: '/'
};

var server = http.createServer(function(req, res) {
const server = http.createServer(function(req, res) {
res.writeHead(200, {'Content-Length':'2'});
res.write('*');
setTimeout(function() { res.end('*'); }, 100);
setTimeout(function() { res.end('*'); }, common.platformTimeout(100));
});

server.listen(options.port, options.host, function() {
var req = http.request(options, onresponse);
const req = http.request(options, onresponse);
req.end();

function onresponse(res) {
Expand Down

0 comments on commit 20acc60

Please sign in to comment.