crypto: make malloc failure check cross-platform

`malloc(0)` may return NULL on some platforms. Do not report out-of-memory error unless `malloc` was passed a number greater than `0`. Fixes: nodejs#7564 PR-URL: nodejs#8352
Trott · Aug 31, 2016 · c641ae0 · c641ae0
1 parent f6e33ef
commit c641ae0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5368,7 +5368,7 @@ class RandomBytesRequest : public AsyncWrap {
         error_(0),
         size_(size),
         data_(static_cast<char*>(malloc(size))) {
-    if (data() == nullptr)
+    if (data() == nullptr && size > 0)
       FatalError("node::RandomBytesRequest()", "Out of Memory");
     Wrap(object, this);
   }

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -27,11 +27,6 @@ test-debug-signal-cluster         : PASS,FLAKY
 test-fs-watch-enoent                 : FAIL, PASS
 test-fs-watch-encoding               : FAIL, PASS
 
-# being worked under https://github.com/nodejs/node/pull/7564
-test-async-wrap-post-did-throw           : PASS, FLAKY
-test-async-wrap-throw-from-callback      : PASS, FLAKY
-test-crypto-random                       : PASS, FLAKY
-
 #being worked under https://github.com/nodejs/node/issues/7973
 test-stdio-closed                        : PASS, FLAKY