Skip to content

Commit

Permalink
build: zlib build error on Windows on Arm
Browse files Browse the repository at this point in the history
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richard-townsend-arm authored and Trott committed Apr 15, 2021
1 parent 3e130a8 commit da216f5
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1605,7 +1605,13 @@
'toolsets': ['host', 'target'],
}],
['OS=="win"', {
'defines': ['X86_WINDOWS'],
'conditions': [
['"<(target_arch)"=="arm64" and _toolset=="target"', {
'defines': ['CPU_NO_SIMD']
}, {
'defines': ['X86_WINDOWS']
}]
]
}],
],
'direct_dependent_settings': {
Expand Down

0 comments on commit da216f5

Please sign in to comment.