Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional return value #16

Merged
merged 6 commits into from
Jan 31, 2021
Merged

Optional return value #16

merged 6 commits into from
Jan 31, 2021

Conversation

brettbuddin
Copy link
Contributor

@brettbuddin brettbuddin commented Jan 29, 2021 •
edited
Loading

I've addressed Go here, but I dunno how it affects OpenAPI v3 🙈

Update: Yes. Don't merge this yet. OpenAPI v3 hates it.

@brettbuddin brettbuddin requested a review from GeorgeMac January 29, 2021 20:00
@GeorgeMac
Copy link
Collaborator

TIL: cuelang/cue#165
CUE currently doesn't allow access to optional values.
I tried taking a stab at fixing this by doing a null check on the return and got the error above.

@GeorgeMac GeorgeMac merged commit 1eea92c into main Jan 31, 2021
@GeorgeMac GeorgeMac deleted the optional-return branch January 31, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac Awaiting requested review from GeorgeMac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettbuddin @GeorgeMac