Allow relative XDG_CONFIG/CACHE_HOME paths #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By converting the environment variable if specified to an absolute path
using the standard library. This allows passing a relative path like,
XDG_CONFIG_HOME=config
XDG_CACHE_HOME=cache
To expand essentially into ${PWD}/config and ${PWD}/cache respectively.
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By converting the environment variable if specified to an absolute path using the standard library. This allows passing a relative path like,
XDG_CONFIG_HOME=config
XDG_CACHE_HOME=cache
To expand essentially into
${PWD}/configand${PWD}/cacherespectively. This also additionally lets you use these variables on windows because paths start with a drive letter e.g.C:/, notos.PathSeparator.PR Target Branch
developbranch for non-release changes.