This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
Use req.hostname for hostname query in axios client #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that the value of X-Forwarded-Host is used whenever trust proxy is enabled, falling back to the normal host header when it is disabled.
christinebrass
commented
Jan 15, 2019
| @@ -47,7 +47,7 @@ export default function getHttpClient( | |||
| // If a request object is provided, then we want to merge the custom headers | |||
| // with the headers that we sent from the browser in the request. | |||
| client = httpClient.create({ | |||
| baseURL: protocol + req.headers.host, | |||
| baseURL: protocol + req.hostname, | |||
There was a problem hiding this comment.
This will fall back to req.get('host') when trust proxy is not enabled:
https://github.com/expressjs/express/blob/4.16.4/lib/request.js#L431-L433
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the value of X-Forwarded-Host is used whenever
trust proxyis enabled, falling back to the normal host header when it is disabled.