This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
Improve production mode #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Perform a clean up before pm2 starts that will make sure there were no phatom processes running before kicking off new phones. (This one helps both production and development) 2. Run the gluestick build as part of creating the image. This way the server will be ready as soon as it starts. Added "skip build" option to arguments so that the docker image will stop kicking off a build when it starts. Kicking off a build is still useful when running locally and you haven't run `gluestick build` before running with NODE_ENV as production.
…ck into toddw/improve-production
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no phantom processes running before kicking off new phones. (This one
helps both production and development)
server will be ready as soon as it starts. Added "skip build" option to
arguments so that the docker image will stop kicking off a build when it
starts. Kicking off a build is still useful when running locally and you
haven't run
gluestick buildbefore running with NODE_ENV asproduction.