Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user-agent #172

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix: user-agent #172

merged 3 commits into from
Jul 29, 2024

Conversation

aitorfernandez
Copy link
Contributor

@aitorfernandez aitorfernandez commented Jul 24, 2024

@aitorfernandez aitorfernandez requested a review from a team as a code owner July 24, 2024 15:32
#[cfg(feature = "deprecated_attributes")]
fn get_header_value(key: &str, headers: &reqwest::header::HeaderMap) -> String {
let header_default = &reqwest::header::HeaderValue::from_static("");
format!("{:?}", headers.get(key).unwrap_or(header_default)).replace('"', "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the requirement to have .replace('"', "") come from 👀 ?

@eopb eopb merged commit c90089e into main Jul 29, 2024
16 checks passed
@eopb eopb deleted the user-agent-issue branch July 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants