-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zonotope updates 1.14 #2070
Zonotope updates 1.14 #2070
Conversation
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev_1.14.0 #2070 +/- ##
==============================================
- Coverage 85.58% 85.58% -0.01%
==============================================
Files 294 294
Lines 26322 26333 +11
Branches 4827 4829 +2
==============================================
+ Hits 22528 22536 +8
- Misses 2564 2565 +1
- Partials 1230 1232 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GiulioZizzo Thank you very much for your pull request! The changes look good to me.
Signed-off-by: GiulioZizzo <giulio.zizzo@yahoo.co.uk>
Description
The zonotope based certified trainer should contain a check as to the type of estimator being passed in. It requires a PytorchDeepZ estimator which new users may not be aware of.
We further improve the code to minimise the amount of pylint suppression and include a more informative progress bar.
Fixes #2032
Type of change
Please check all relevant options.
Testing
Current zonotope tests pass and results are consistent
Test Configuration:
Checklist