Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing README download badges #2266

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fixing README download badges #2266

merged 3 commits into from
Sep 7, 2023

Conversation

naoise-h
Copy link
Contributor

Description

The url of the pepy badges (for downloads) have changed recently. This PR makes sure the badges point to the correct url.

Fixes # (issue)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

No tests are required. The fix is confirmed by visual inspection.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Naoise Holohan <naoise@nholohan.ie>
@beat-buesser beat-buesser self-requested a review September 1, 2023 10:54
@beat-buesser beat-buesser self-assigned this Sep 1, 2023
@beat-buesser beat-buesser added improvement Improve implementation documentation Documentation updates labels Sep 1, 2023
Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naoise-h Thank you very much! I hadn't noticed the change until now. Could you please add the same change to the other readme file README-cn.md?

Signed-off-by: Naoise Holohan <naoise@nholohan.ie>
@naoise-h
Copy link
Contributor Author

naoise-h commented Sep 4, 2023

Hi @naoise-h Thank you very much! I hadn't noticed the change until now. Could you please add the same change to the other readme file README-cn.md?

Done!

Signed-off-by: Naoise Holohan <naoise@nholohan.ie>
@beat-buesser beat-buesser merged commit 7bb45ed into Trusted-AI:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation updates improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants