Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in random sampling of patch locations in masks for adversarial patch attacks #2539

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

beat-buesser
Copy link
Collaborator

Description

This pull request fixes a bug in the random sampling of patch locations in masks for adversarial patch attacks.

dependabot bot and others added 5 commits October 22, 2024 07:59
Bumps [torch](https://github.com/pytorch/pytorch) from 2.2.1 to 2.5.0.
- [Release notes](https://github.com/pytorch/pytorch/releases)
- [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v2.2.1...v2.5.0)

---
updated-dependencies:
- dependency-name: torch
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
@beat-buesser beat-buesser self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (cf11263) to head (20f8e27).
Report is 9 commits behind head on dev_1.19.0.

Files with missing lines Patch % Lines
...ion/adversarial_patch/adversarial_patch_pytorch.py 85.71% 0 Missing and 2 partials ⚠️
...ion/imperceptible_asr/imperceptible_asr_pytorch.py 50.00% 1 Missing ⚠️
...mators/object_detection/pytorch_object_detector.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           dev_1.19.0    #2539   +/-   ##
===========================================
  Coverage       85.41%   85.41%           
===========================================
  Files             334      334           
  Lines           31000    31001    +1     
  Branches         5299     5300    +1     
===========================================
+ Hits            26478    26481    +3     
+ Misses           3054     3053    -1     
+ Partials         1468     1467    -1     
Files with missing lines Coverage Δ
art/attacks/evasion/saliency_map.py 100.00% <100.00%> (ø)
art/estimators/classification/pytorch.py 86.45% <ø> (ø)
art/estimators/regression/pytorch.py 14.20% <ø> (ø)
...ion/imperceptible_asr/imperceptible_asr_pytorch.py 86.25% <50.00%> (ø)
...mators/object_detection/pytorch_object_detector.py 88.83% <0.00%> (-0.46%) ⬇️
...ion/adversarial_patch/adversarial_patch_pytorch.py 76.35% <85.71%> (ø)

... and 2 files with indirect coverage changes

Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Dec 17, 2024
@beat-buesser beat-buesser added this to the ART 1.19.0 milestone Dec 17, 2024
Signed-off-by: Beat Buesser <beat.buesser@ibm.com>
@beat-buesser beat-buesser merged commit f89ee1b into dev_1.19.0 Dec 18, 2024
61 checks passed
@beat-buesser beat-buesser deleted the development_patch_mask branch December 18, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant