-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Feedly URL and to HTTPS protocol #418
Conversation
Thanks for the report. I tested the W3C link checker that you referred to with the old and the new URL from your blog and I can't see any difference. Can you provide some more information, why it is relevant to change the URL? Thanks! |
Yes, because I fixed my local installation already according to the output the validator. |
I tested it with the changed URL as well as the URL it was before (also with other blogs) and couldn't see a difference to the URL you submitted in this PR. |
Hi @AileenCGN Okay, I think it's still not clear what I'm trying to say. Please use the following W3C link checker result. The Ghost template used on that domain is derived from Casper, and produces the following link for the RSS button: href="http://cloud.feedly.com/#subscription/feed/https://www.mscc.mu/rss/" - that generated href-value is outdated. When you actually following the link, Feedly redirects you once more to the final URL using https://feedly.com/ instead of http://cloud.feedly.com/ The generated URL in the RSS button by Casper should read like so: href="https://feedly.com/i/subscription/feed/https://www.mscc.mu/rss/" instead. Hope this helps. Best regards, Jochen |
@jochenkirstaetter Gotcha! Thanks for the further explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully. LGTM 👍
Hi @AileenCGN |
Hi,
Given that the W3C Link Checker marks the current URL of using Feedly as a permanent redirect (HTTP 301) it should be relevant to update the anchor sources accordingly in the default template, too.
Line: 120 http://cloud.feedly.com/ redirected to https://cloud.feedly.com/
Status: 301 -> 200 OK
This is a permanent redirect. The link should be updated to point to the more recent URI.
Broken fragments:
http://cloud.feedly.com/#subscription/feed/https://jochen.kirstaetter.name/rss/ (line 120)
Thanks for consideration.
Regards, Jochen