Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feedly URL and to HTTPS protocol #418

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

jochenkirstaetter
Copy link
Contributor

@jochenkirstaetter jochenkirstaetter commented Jan 4, 2018

Hi,

Given that the W3C Link Checker marks the current URL of using Feedly as a permanent redirect (HTTP 301) it should be relevant to update the anchor sources accordingly in the default template, too.

Line: 120 http://cloud.feedly.com/ redirected to https://cloud.feedly.com/
Status: 301 -> 200 OK
This is a permanent redirect. The link should be updated to point to the more recent URI.

Broken fragments:
http://cloud.feedly.com/#subscription/feed/https://jochen.kirstaetter.name/rss/ (line 120)

Thanks for consideration.

Regards, Jochen

@jochenkirstaetter jochenkirstaetter changed the title Change Feedly URL to HTTPS protocol Update Feedly URL and to HTTPS protocol Jan 4, 2018
@aileen
Copy link
Member

aileen commented Jan 8, 2018

Hey @jochenkirstaetter

Thanks for the report.

I tested the W3C link checker that you referred to with the old and the new URL from your blog and I can't see any difference.

See the old result:
screencapture-validator-w3-org-checklink-1515401322030

Compared to the new result:
screencapture-validator-w3-org-checklink-1515401163158

Can you provide some more information, why it is relevant to change the URL?

Thanks!

@jochenkirstaetter
Copy link
Contributor Author

Yes, because I fixed my local installation already according to the output the validator.

@aileen
Copy link
Member

aileen commented Jan 11, 2018

I tested it with the changed URL as well as the URL it was before (also with other blogs) and couldn't see a difference to the URL you submitted in this PR.

@jochenkirstaetter
Copy link
Contributor Author

Hi @AileenCGN

Okay, I think it's still not clear what I'm trying to say. Please use the following W3C link checker result.
This checks the URLs in a Ghost blog instead of the Feedly URL that you checked.

The Ghost template used on that domain is derived from Casper, and produces the following link for the RSS button: href="http://cloud.feedly.com/#subscription/feed/https://www.mscc.mu/rss/" - that generated href-value is outdated.
The W3C link checker result indicates the change from HTTP to HTTPS, too.

image

When you actually following the link, Feedly redirects you once more to the final URL using https://feedly.com/ instead of http://cloud.feedly.com/

The generated URL in the RSS button by Casper should read like so: href="https://feedly.com/i/subscription/feed/https://www.mscc.mu/rss/" instead.
My PR simply updates the protocol and domain part of the RSS button code in the Casper template, as seen here.

Hope this helps.

Best regards, Jochen

@HLFH HLFH mentioned this pull request Jan 22, 2018
@HLFH
Copy link

HLFH commented Jan 22, 2018

@AileenCGN Hi. Can you please close #424 and merge #418 ? Thanks

@aileen
Copy link
Member

aileen commented Jan 23, 2018

@jochenkirstaetter Gotcha! Thanks for the further explanation!

Copy link
Member

@aileen aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully. LGTM 👍

@aileen aileen merged commit bfaae0f into TryGhost:master Jan 23, 2018
@jochenkirstaetter
Copy link
Contributor Author

Hi @AileenCGN
Awesome, thanks for accepting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants