Skip to content

Commit

Permalink
🐛 Fixed url decoding issue - URLs sent in emails containing a % can n…
Browse files Browse the repository at this point in the history
…ow be updated(#20518)

fixes https://linear.app/tryghost/issue/ENG-447/🐛-urls-sent-in-emails-containing-a-percent-can-not-be-updated

URLs were decoded before making a search query to the db. This is the reason the `%2F` character gets converted to  `/`. This decoding is not required.
  • Loading branch information
vershwal authored Jul 2, 2024
1 parent b36c235 commit bec6474
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ghost/link-tracking/lib/LinkClickTrackingService.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ class LinkClickTrackingService {
* @throws {errors.BadRequestError}
*/
#parseLinkFilter(filter) {
// decode filter to manage any encoded uri components
filter = decodeURIComponent(filter);

try {
const filterJson = nql(filter).parse();
const postId = filterJson?.$and?.[0]?.post_id;
Expand Down

0 comments on commit bec6474

Please sign in to comment.