Added yarn cache to CI workflows
#13716
Conversation
|
@daniellockyer I did a cleanup of my forks and I had to re-generate the fork, PR's and so (not sure if there was a way to link everything). Closing old PR |
Codecov Report
@@ Coverage Diff @@
## main #13716 +/- ##
==========================================
- Coverage 56.28% 56.27% -0.01%
==========================================
Files 552 552
Lines 46028 46028
Branches 4127 4127
==========================================
- Hits 25906 25902 -4
- Misses 20078 20083 +5
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
|
@oscard0m Thanks for the updated PR! It looks good to me the the |
|
OMG! Do you plan to block this until that issue is addressed? @daniellockyer |
refs #13716 refs actions/setup-node#317 (comment) - the `setup-node` GitHub Action seems to use a shell command to get the cache path, but these are colorised when `FORCE_COLOR` is enabled - this causes the Action to fail to read the path correctly - the comment referenced above suggests to remove `FORCE_COLOR` but it's nice to have colored output for our tests - instead, I'm disabling the environment variable on the `setup-node` action so it still works - I've tested with the referenced PR and this unblocks dependency caching 🎉
|
@oscard0m I've implemented a workaround so we didn't have to disable If you'd just like to give it a quick rebase + then we should be good to merge 🙂 |
Thanks @daniellockyer . Rebased pushed. Let's see what the CI says now 🍿 |
daniellockyer
changed the title
yarn cache to CI workflows
|
@oscard0m Thanks for the PR! 🕺🏻 |
Description
Add
cacheto workflows usingactions/setup-nodeContext
setup-nodeGitHub Action just released a new option to add cache to steps using it.You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
Re-generated PR from #13597
🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾