Switched to mysql2 library
#14258
Merged
Switched to mysql2 library
#14258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14258 +/- ##
==========================================
- Coverage 55.43% 55.41% -0.02%
==========================================
Files 564 564
Lines 46704 46708 +4
Branches 3974 3975 +1
==========================================
- Hits 25889 25885 -4
- Misses 20774 20782 +8
Partials 41 41
Continue to review full report at Codecov.
|
daniellockyer
force-pushed
the
mysql2
branch
4 times, most recently
from
f87dcff
to
0c6e2f8
Compare
daniellockyer
changed the title
mysql2 DB clientmysql2 library
refs TryGhost/Toolbox#174 - this commit switches Ghost from using the `mysql` library to the `mysql2` one - we've done this for several reasons: - `mysql2` is more actively maintained - `mysql2` natively supports the default auth plugin on MySQL 8 - `mysql2` is fasterrrr - there have been various other commits refactoring the groundwork for this commit but this commit should be short and sweet: - alias `mysql` to `mysql2` client so we maintain backwards compatibility with all configs who use `"client": "mysql"` - enabled `decimalNumbers` so we maintain the same functionality as `mysql` - replaced the dependencies and updated `knex-migrator` - hardcoded the newer authentication plugin in MySQL 8 CI. Before switching to `mysql2`, this would break because it didn't support this
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Toolbox/issues/174
mysqllibrary to themysql2onemysql2is more actively maintainedmysql2natively supports the default auth plugin on MySQL 8mysql2is fasterrrrthis commit but this commit should be short and sweet:
mysqltomysql2client so we maintain backwardscompatibility with all configs who use
"client": "mysql"decimalNumbersso we maintain the same functionality asmysqlknex-migratorswitching to
mysql2, this would break because it didn't supportthis