🐛 Fixed default sort for the content API posts endpoint with included… #20333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relations ref https://linear.app/tryghost/issue/CFR-31/ - when relations were included, erroneous logic resulted in the model's default sort being applied - the model default sort is not intended for the content API and needlessly slowed down responses - there's a very minor change for users here; default sort is `published_at desc` which will be secondarily sorted by `id asc` (SQL default for primary key) instead of `published_at desc, updated_at desc, id desc` This is a very significant performance improvement for content API requests with includes for sites with a significant amount of data, which will primarily impact those using Ghost as a CMS or theme {{#get}} helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… relations
ref https://linear.app/tryghost/issue/CFR-31/
published_at descwhich will be secondarily sorted byid descinstead ofpublished_at desc, updated_at desc, id descThis is a very significant performance improvement for content API requests with includes for sites with a significant amount of data, which will primarily impact those using Ghost as a CMS or theme {{#get}} helpers.