Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improved editor behavior to automatically update slug for draft posts #20388

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

9larsons
Copy link
Contributor

ref https://linear.app/tryghost/issue/ENG-1211

  • the post slug now re-generates based on the post title for draft posts unless manually set; this logic resets for each post that is loaded

It's frequently the case that draft posts might have WIP titles. We would generate a post slug based on the title and never change it, so unless writers remembered to come back in to update it for their final post, it could look off to readers. This should make that a bit more intelligent.

ref https://linear.app/tryghost/issue/ENG-1211
- the post slug now re-generates based on the post title for draft posts unless manually set; this logic resets for each post that is loaded

It's frequently the case that draft posts might have WIP titles. We would generate a post slug based on the title and never change it, so unless writers remembered to come back in to update it for their final post, it could look off to readers. This should make that a bit more intelligent.
@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Jun 13, 2024
ref https://linear.app/tryghost/issue/ONC-94
- added Sentry logging for unsaved changes modal so we can track the volume of popups for users

This can be helpful to track in the event we make changes to the model/Admin that cause our dirtyAttributes logic to be faulty.
@9larsons 9larsons merged commit d732f83 into main Jun 17, 2024
19 checks passed
@9larsons 9larsons deleted the slug-update-draft-posts branch June 17, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant