🐛 Fixed bug with persisting offer redemptions for existing free members #20571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/ENG-1251/support-escalation-re-offers-not-tracking - Previously, Ghost recorded an offer redemption in the DB in response to the SubscriptionCreatedEvent, under the assumption that the offer details would be included in this event. - However, for existing free members, the SubscriptionCreatedEvent first occurs in response to the `subscription.created` Stripe webhook, which does not include the offer details. - The offer details are only included in the `checkout.session.completed` webhook, which updated the subscription in the DB to include the offer details, but this update did not trigger the offer redemption. - Consequently, Ghost wasn't recording offer redemptions for existing free members who were redeeming an offer for a paid subscription. - This change adds an explicit `OfferRedemptionEvent`, which triggers either when a new subscription is created with an offer (as in the case of a brand new member), or when an existing subscription is first updated to include an offer (as in the case of an existing free member upgrading with an offer).
cmraible
changed the title
cmraible
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ENG-1251/support-escalation-re-offers-not-tracking
SubscriptionCreatedEvent, under the assumption that the offer details would be included in this event. This assumption was valid for brand new members starting a subscription with an offer, but not for existing free members upgrading to a paid plan with an offer.customer.subscription.createdStripe webhook. At this point, the offer/discount is not attached to the subscription, so theSubscriptionCreatedEventtriggers without the offer information, and the offer redemption is not recorded. After thecheckout.session.completedwebhook is received (which does include the offer details), the subscription is updated in Ghost, but the Offer Redemption is not stored.customer.subscription.createdwebhook no-ops, because the member and Stripe Customer don't exist yet. Therefore, the subscription is first created in Ghost in response to thecheckout.session.completedwebhook, which does include the offer information, so the offer information is included in theSubscriptionCreatedEventand the offer redemption is recorded as expected.OfferRedemptionEvent, which triggers either: (1) when a new subscription is created with an offer (as in the case of a brand new member), or (2) when an existing subscription is first updated to include an offer (as in the case of an existing free member upgrading with an offer). The Offer Redemption is then persisted in the DB in response to theOfferRedemptionEventrather than theSubscriptionCreatedEvent.