🐛 Fixed data importer allowing invalid free product to be imported #20572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs [ENG-1355](https://linear.app/tryghost/issue/ENG-1355/site-boot-cycling-due-to-free-tier-having-a-currency) Fixed data importer allowing invalid free product to be imported which could cause Ghost to not start due to the error: `ValidationError: Free Tiers cannot have a currency` It should not be possible to import a free product with pricing data (as that means its not free 😄)
mike182uk
deleted the
mike-eng-1355-site-boot-cycling-due-to-free-tier-having-a-currency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ENG-1355
Fixed data importer allowing invalid free product to be imported which could cause Ghost to not start due to the error:
ValidationError: Free Tiers cannot have a currencyIt should not be possible to import a free product with pricing data (as that means its not free 😄)