🐛 Removed method="post" on sign in/up forms in Admin #20598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/ONC-160 - POST is incorrect as the form itself doesn't post to any path; all we want are the authentication flows to kick off on submit We've had reports of users experiencing a 404 error on attempting to sign in to Ghost Admin (at /ghost/), where the login form seems to submit a POST request to the /ghost/ path (we don't have a route for that method, hence the 404; only GET). While I haven't been able to reproduce the issue, there's very few places in Ghost that actually issue a POST request. Removing this method here has no impact to Ghost auth and may prevent some unexpected default behavior from the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ONC-160
We've had reports of users experiencing a 404 error on attempting to sign in to Ghost Admin (at /ghost/), where the login form seems to submit a POST request to the /ghost/ path (we don't have a route for that method, hence the 404; only GET). While I haven't been able to reproduce the issue, there's very few places in Ghost that actually issue a POST request.
Removing this method here has no impact to Ghost auth and may prevent some unexpected default behavior from the browser.