-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed migrations for SQLite database users (#19839) #21063
Conversation
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
Just thought I'd add that I ran into this problem when updating a local instance from 5.53.3 to 5.96.0, with about 600 posts. Changing the value in .../5.55/2023-07-10-05-16-55-add-built-in-collection-posts.js from 1000 to 450 didn't work, but when I changed it to 100, as @DigitalLeaves suggested, it then worked. Supposing I'm correctly following what I did. |
The default for It seems like 450 isn't low enough to fix the problem either! I'm going to close this PR as it doesn't seem particularly active - if someone wants to fix it, then please check out the original issue where I'll leave some more information. |
@markstos I wasn't sure if you have permissions to reopen this - so I've done it for you! |
SQLite has limit of 500 items in a compound select statement. This limit could be hit when a complex SELECT statement was being generated as part of a batch insert statement. Lowering the batch size will have minimal impact on migration performance while improving SQLite compatibility. Ref: https://www.sqlite.org/limits.html Issue: TryGhost#19839
8897c02
to
db481b1
Compare
Commit pushed to lower batch size to 100. |
…st#21063) refs TryGhost#19839 refs https://www.sqlite.org/limits.html SQLite has limit of 500 items in a compound select statement. This limit could be hit when a complex select statement was being generated as part of a batch insert statement. Lowering the batch size will have minimal impact on migration performance while improving SQLite compatibility. One of these bulk inserts is confirmed to be affected through the linked issue. I didn't confirm if the other two cases would trigger it, but the change won't hurt there either.
SQLite has limit of 500 items in a compound select statement.
This limit could be hit when a complex select statement was being generated
as part of a batch insert statement.
Lowering the batch size will have minimal impact on migration performance
while improving SQLite compatibility.
One of these bulk inserts is confirmed to be affected through the linked issue.
I did confirm if the other two cases would trigger it, but the change won't hurt there
either.
Ref: https://www.sqlite.org/limits.html
Issue: #19839