Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐✨i18n for newsletter strings #21433

Merged
merged 49 commits into from
Oct 31, 2024
Merged

🌐✨i18n for newsletter strings #21433

merged 49 commits into from
Oct 31, 2024

Commits on Oct 27, 2024

  1. initial commit iwth date error

    @cathysarisky
    cathysarisky committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    4d60bcb View commit details
    Browse the repository at this point in the history

  2. almost there!

    @cathysarisky
    cathysarisky committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    4960f84 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fixed!

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3a7c50f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into newsletter-t

    @cathysarisky
    cathysarisky authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3c3aa27 View commit details
    Browse the repository at this point in the history

  3. ah lint

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6ae2844 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost … 

    …into newsletter-t
    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8834ef6 View commit details
    Browse the repository at this point in the history

  5. dangit lint

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e88c57c View commit details
    Browse the repository at this point in the history

  6. stray space = failed test :(

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7f66b14 View commit details
    Browse the repository at this point in the history

  7. add a test

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea627fa View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into newsletter-t

    @cathysarisky
    cathysarisky authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1774caa View commit details
    Browse the repository at this point in the history

  9. date i18n

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea617f4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost … 

    …into newsletter-t
    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d1eabc7 View commit details
    Browse the repository at this point in the history

  11. belly button lint?

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d095750 View commit details
    Browse the repository at this point in the history

  12. issues with imports?

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d8d5de5 View commit details
    Browse the repository at this point in the history

  13. import issues

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cb401ed View commit details
    Browse the repository at this point in the history

  14. build error?

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    35a639a View commit details
    Browse the repository at this point in the history

  15. tweak imports again?

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    49aec51 View commit details
    Browse the repository at this point in the history

  16. hating importing.

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    3afc818 View commit details
    Browse the repository at this point in the history

  17. try building, probably fail lint.

    @cathysarisky
    cathysarisky committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c1100c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. only one failing test?

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0cf65a0 View commit details
    Browse the repository at this point in the history

  2. t fun.

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    01e5bdb View commit details
    Browse the repository at this point in the history

  3. e2e test fix?

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    869ea0b View commit details
    Browse the repository at this point in the history

  4. test fussing

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6240f25 View commit details
    Browse the repository at this point in the history

  5. test wrangling

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6c0adf3 View commit details
    Browse the repository at this point in the history

  6. better test

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2d29b78 View commit details
    Browse the repository at this point in the history

  7. lint is hard

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7922bcd View commit details
    Browse the repository at this point in the history

  8. make buttons translatable

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bde1755 View commit details
    Browse the repository at this point in the history

  9. preliminary update of snapshots for translatable buttons

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    071cf48 View commit details
    Browse the repository at this point in the history

  10. argh, package.json...

    @cathysarisky
    cathysarisky authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1c51718 View commit details
    Browse the repository at this point in the history

  11. fix dates... again.

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    abc4d7b View commit details
    Browse the repository at this point in the history

  12. Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost … 

    …into newsletter-t
    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4d35d31 View commit details
    Browse the repository at this point in the history

  13. added a creation date - my mock is too good, and needs one to make th… 

    …e snapshots work!
    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d6639fd View commit details
    Browse the repository at this point in the history

  14. date localization problem fixed?

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fbe7250 View commit details
    Browse the repository at this point in the history

  15. and the snap

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ba30684 View commit details
    Browse the repository at this point in the history

  16. test tweaks

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    156775b View commit details
    Browse the repository at this point in the history

  17. Updated feedback button styling 

    No issue
- Removed all mobile feedback button code
- Updated styling of feedback buttons to display in a single row on desktop and column on mobile
    @sanne-san
    sanne-san committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2fc2c6a View commit details
    Browse the repository at this point in the history

  18. Cover last lines in unit test

    @9larsons
    9larsons committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    253608a View commit details
    Browse the repository at this point in the history

  19. fix broken test

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8456170 View commit details
    Browse the repository at this point in the history

  20. more broken tests

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3cc0380 View commit details
    Browse the repository at this point in the history

  21. fix snapshots in places I didn't know we had snapshots.

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e66ff34 View commit details
    Browse the repository at this point in the history

  22. more snapshots.

    @cathysarisky
    cathysarisky committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cc2fc1c View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into newsletter-t

    @cathysarisky
    cathysarisky authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a3ff9cc View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. remove unused tpl, improve handling of dynamic strings (sort of)

    @cathysarisky
    cathysarisky committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e970cca View commit details
    Browse the repository at this point in the history

  2. must... write... better... code

    @cathysarisky
    cathysarisky committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    124d5df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into newsletter-t

    @cathysarisky
    cathysarisky authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5d4029e View commit details
    Browse the repository at this point in the history

  4. i18nmerge fussing

    @cathysarisky
    cathysarisky committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ba82ea9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into newsletter-t

    @cathysarisky
    cathysarisky authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    38cdf3b View commit details
    Browse the repository at this point in the history

  2. trying to make i18n parser play nice

    @cathysarisky
    cathysarisky committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3d442a7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost … 

    …into newsletter-t
    @cathysarisky
    cathysarisky committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e124d6e View commit details
    Browse the repository at this point in the history