Added from address to autocreated mail configuration #21442
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathysarisky
added a commit
to cathysarisky/Ghost
that referenced
this pull request
Oct 31, 2024
commit 361d88b Merge: fcc6314 4c79887 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Thu Oct 31 13:23:45 2024 -0400 Merge branch 'main' into theme-i18n commit 4c79887 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Oct 31 16:39:05 2024 +0000 Update dependency compression to v1.7.5 commit fe2cff4 Author: Hannah Wolfe <github.erisds@gmail.com> Date: Thu Oct 31 16:36:44 2024 +0000 Moved search i18n behind labs flag (TryGhost#21488) - When we added i18n for search we missed gating it behind the i18n flag. - There aren't that many translations for search yet, so it's likely not many have noticed yet - We'll remove the flag soon, but until then, adding the flag for consistency :) commit 3ecfe08 Author: Michael Barrett <mike@ghost.org> Date: Thu Oct 31 16:34:53 2024 +0000 Added failure state for reply in admin-x-activitypub (TryGhost#21487) no refs Added a failure state for when a reply fails to be sent commit f601ab3 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Thu Oct 31 11:32:34 2024 -0400 ✨ Added "exclude" option for customizing {{ghost_head}} (TryGhost#21229) no ref {{ghost_head}} is huge, and some power-users and theme creators want the ability to customize what it contains. This PR makes it easier for a theme to write custom schema, or to load a custom version of portal/comments/search/etc, or to minimize load times by not loading scripts where they aren't needed, in a theme-specific way. Because ghost_head is controlled at the theme level, this gives folks in managed hosting the new ability to load a different version of the included app scripts (by preventing ghost_head from writing them and adding them in manually). Usage example: ` {{ghost_head exclude="search,portal"}} ` (empty array) No changes to current behavior search The built-in sodo-search script Includes adding the click event listener on buttons, generating the search index, and the UI. portal The portal script Handles sign-in and sign-up, payments, tips, memberships, etc, and all the portal data-attributes. announcement The announcement bar javascript If you'd like to use the announcement bar admin settings but not have it [mess up your CLS metric](https://www.spectralwebservices.com/blog/announcement-bar-a-review/), this is for you. metadata Skips HTML tags for meta description, favicon, canonical url, robots, referrer Important for SEO schema The LD+JSON schema Important for SEO card_assets Loads cards.min.css and .js Needed on any page with a post body, unless your theme replaces them all. Assets can also be selectively loaded with the [card_assets override](https://ghost.org/docs/themes/content/?ref=spectralwebservices.com#editor-cards) comment_counts Loads the comment_counts helper Needed if the page is using {{comments}} or data-ghost-comment-count attribute social_data Produces the og: and twitter: attributes for social media sharing and previews Required for good social media cards cta_styles Removes the call to action (CTA) styles Used for member signup and CTA cards - may be overwritten by your theme already commit 7e50a40 Author: Kevin Ansfield <kevin@lookingsideways.co.uk> Date: Thu Oct 31 14:10:31 2024 +0000 Improved error log when Twitter enhanced oembed fails ref https://linear.app/ghost/issue/ONC-506 - adding `context` with the returned API response makes the logged error much more useful as without it we only log the status code which misses any details for why the failure occurred commit 1d429b8 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Thu Oct 31 09:41:39 2024 -0400 🌐✨Added i18n for newsletter strings (TryGhost#21433) no issue This PR adds the ability to translate the strings that appear in the newsletter as boilerplate text, using i18next. Variables are in single mustaches ( `{date}` ) in the translation strings (rather than `{{date}}`), because these strings occur both the email template.hbs and also .js files. That necessitated a separate namespace. This PR also includes changes to the newsletter button ("more like this", "less like this", "comment") that were previously delivered on desktop as images that included the text. @sanne-san provided a rework that removed text-as-image from the desktop buttons, and allows more shared code between the two layouts, along with making the buttons translatable. Example usage - handlebars ``` <h3 class="latest-posts-header">{{t 'Keep reading'}}</h3> {{{t 'By {authors}' authors=post.authors }}} ``` (NOTE: triple { required because of possible & ) Example usage - javascript ``` getValue: (member) => { if (member.status === 'comped') { return t('complimentary'); } if (this.isMemberTrialing(member)) { return t('trialing'); } // other possible statuses: t('free'), t('paid') // return t(member.status); } ``` --------- Co-authored-by: Sanne de Vries <sannedv@protonmail.com> Co-authored-by: Steve Larson <9larsons@gmail.com> commit dd2ed27 Author: Michael Barrett <mike@ghost.org> Date: Thu Oct 31 11:40:41 2024 +0000 Removed unused `useAllActivitiesForUser` hook and related code in admin-x-activitypub app (TryGhost#21482) no refs Removed unused `useAllActivitiesForUser` hook and related code. This was a left over from when we added paginated activities commit 085afde Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Oct 31 10:53:43 2024 +0000 Pin dependency clsx to 2.1.1 commit 45711e1 Author: Djordje Vlaisavljevic <dzvlais@gmail.com> Date: Thu Oct 31 10:50:51 2024 +0000 AP design bugs (TryGhost#21395) - Fixed links in profile description - Stripped post content - Fixed grey bg in Avatars - Installed `clsx` --------- Co-authored-by: Michael Barrett <mike@ghost.org> commit 4f46624 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Oct 31 10:11:27 2024 +0000 Update Koenig packages (TryGhost#21480) commit 824efc7 Author: Djordje Vlaisavljevic <dzvlais@gmail.com> Date: Thu Oct 31 10:07:52 2024 +0000 Added UUID as data attribute to posts in all views (TryGhost#21470) ref https://linear.app/ghost/issue/AP-404/add-uuid-as-a-data-attribute-in-the-dom-for-easier-db-lookup - This will allow us to find posts in the DB Co-authored-by: Michael Barrett <mike@ghost.org> commit becfd13 Author: Djordje Vlaisavljevic <dzvlais@gmail.com> Date: Thu Oct 31 09:58:47 2024 +0000 Refactored handleViewContent so it can be reused (TryGhost#21468) ref https://linear.app/ghost/issue/AP-540/clicking-comment-icon-on-posts-and-likes-tabs-of-your-profile-doesnt - We want to open posts in the drawer from multiple views (Inbox, Profile etc.) and this change allows us to do so by pulling `handleViewContent` from `Inbox.tsx` into a utility function. At the same time, we’ve simplified the function so it uses less props to achieve the same functionality. - Also added a simple fix for scrolling the reply-box into view when opening a long `article` by clicking on the reply icon. We probably still need to figure out a more robust solution, because the height of the `iframe` and the fact it takes some time to load it sometimes gets in the way. Co-authored-by: Michael Barrett <mike@ghost.org> commit 5f59dda Author: Michael Barrett <mike@ghost.org> Date: Thu Oct 31 09:38:52 2024 +0000 Updated replies implementation to use thread mechanism in admin-x-activitypub (TryGhost#21465) refs: - https://linear.app/ghost/issue/AP-439/seeing-parent-post-for-replies - https://linear.app/ghost/issue/AP-481/reply-ui - https://linear.app/ghost/issue/AP-482/replies-to-a-post-should-be-visible-when-opening-it Updated the replies implementation to make use of the new thread mechanism. This allows for a more sane approach to handling replies as well as making it possible to show the parent of a reply in the UI --------- Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com> commit ea6d3a0 Author: Daniel Lockyer <hi@daniellockyer.com> Date: Thu Oct 31 09:45:14 2024 +0100 ⚡️ Optimized fetching strings from the settings cache fix https://linear.app/ghost/issue/ENG-1105/settingscacheget-is-slow - through profiling and flamegraphs, we can see that `_doGet` is one of the bottlenecks during high traffic times, sometimes taking up to 20% of the CPU time when hammering Ghost with `wrk` - this is because, for the majority of settings cache lookup, we're running `JSON.parse`, which blocks the main thread - whilst we're only parsing small strings, we're doing it a LOT, sometimes hundreds of times per request, which adds up - this code just throws most deserializing at `JSON.parse`, so if we can stop it from doing that, it'd be a huge win - my initial attempts here were to convert the _doGet function to a smarter deserializing, by looking up `cacheEntry.type` and acting accordingly - however, it became a bit of a logical nightmare, and difficult to reason about for now (i still think we should do it) - therefore, I'm just doing to add a hotpath fix to catch 99% of usecases, which is checking the type of the cache entry and returning the value if it's a string - on a trivial benchmark locally, this causes Ghost to return 30% more requests per second!! commit fa31176 Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com> Date: Thu Oct 31 13:43:39 2024 +0800 Removed Prata font (TryGhost#21478) ref DES-926 commit e01b952 Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com> Date: Thu Oct 31 13:30:25 2024 +0800 Made the tabs sticky in design and newsletter settings (TryGhost#21477) ref DES-927, DES-928 commit 87e24f6 Author: Ronald Langeveld <hi@ronaldlangeveld.com> Date: Thu Oct 31 12:28:44 2024 +0900 Revert "Enhanced Comments Ordering for Best Liked Sorting (TryGhost#21473)" (TryGhost#21475) This reverts commit fd18a39. commit fd18a39 Author: Ronald Langeveld <hi@ronaldlangeveld.com> Date: Thu Oct 31 10:44:15 2024 +0900 Enhanced Comments Ordering for Best Liked Sorting (TryGhost#21473) ref PLG-220 - Improved `getBestComments` service to paginate correctly since we're using a custom query to determine the top comments that goes beyond the scope of what `findPage` is capable of. - Updated CommentsController and CommentsService to support custom order parameters. - Added tests commit fe9b019 Author: Chris Raible <chris@ghost.org> Date: Wed Oct 30 12:39:41 2024 -0700 Cleaned up browser test output in CI (TryGhost#21462) no issue - The browser test output in CI is really noisy, because the `NX_DAEMON` doens't run in CI, but we're trying to use NX to watch and rebuild the typescript modules. This is outputting a ton of "NX Daemon is not running" type of errors, which make it difficult to sift through the actual test results. - We don't actually need to watch the typescript files, we just need to build them once before starting. This is defined as an NX dependency for the browser tests target, so we don't need to explicitly build the TS packages at all. Removing the typescript watch & build command removes the noisy errors, without impacting how the tests actually run. commit 30fc2f3 Author: Chris Raible <chris@ghost.org> Date: Wed Oct 30 11:56:10 2024 -0700 Added `ps` dependency to Dockerfile (TryGhost#21471) no issue - When stopping `yarn dev` with ctrl+c in the dev container, you'd get an error because the container doens't have `ps` installed, which is used by node under the hood. Adding this dependency fixed the error so `yarn dev` (and other commands) exit cleanly commit fbad9f1 Author: matsbst <matsbst@icloud.com> Date: Wed Oct 30 16:38:46 2024 +0100 🌐 Added new and improved Norwegian translation (TryGhost#21452) - New and improved Norwegian translation. All strings translated. commit 97e756e Author: Steve Larson <9larsons@gmail.com> Date: Wed Oct 30 09:18:06 2024 -0500 Bumped Portal and search packages (TryGhost#21467) no ref These had new minors shipped without a bump in Ghost core. commit fcc6314 Merge: 2ed00b6 98c06f8 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Wed Oct 30 09:35:24 2024 -0400 Merge branch 'main' into theme-i18n commit 98c06f8 Author: Kevin Ansfield <kevin@lookingsideways.co.uk> Date: Wed Oct 30 11:47:15 2024 +0000 Fixed removal of event tracker requests in Sentry no issue - filtering was previously added to breadcrumbs but that wasn't enough to clean up Sentry reports - added filtering to the `beforeSend` hook too so reports don't get cluttered with unhelpful XHR noise commit cca6a38 Author: Ronald Langeveld <hi@ronaldlangeveld.com> Date: Wed Oct 30 19:06:11 2024 +0900 Patched Comments UI v0.20.1 (TryGhost#21464) no issue --------- Co-authored-by: Sanne de Vries <65487235+sanne-san@users.noreply.github.com> commit 119a913 Author: Sanne de Vries <65487235+sanne-san@users.noreply.github.com> Date: Wed Oct 30 09:56:42 2024 +0100 Fixed comment form being cut off at the top (TryGhost#21463) No ref commit d4d45de Author: Chris Raible <chris@ghost.org> Date: Tue Oct 29 19:22:58 2024 -0700 Added github-cli and some zsh plugins to dev container (TryGhost#21460) no issue - The Dev Container didn't have the Github CLI installed, so this adds that using Dev Container "[features](https://containers.dev/implementors/features/)" - It also adds oh-my-zsh and a few plugins that are nice to have when developing. commit eb9483a Author: Chris Raible <chris@ghost.org> Date: Tue Oct 29 15:21:46 2024 -0700 Fixed git remote configuration in dev container (TryGhost#21459) no issue - When creating a dev container, the onCreateCommand script will try to setup the git remotes according to the environment variables defined for e.g. `$GHOST_UPSTREAM`. There was a bug that caused the `origin` remote to successfully be renamed to `$GHOST_UPSTREAM`, but the `origin` remote was not being created successfully on the first try. This commit fixes that bug. commit 1d24b2c Author: Chris Raible <chris@ghost.org> Date: Tue Oct 29 14:52:44 2024 -0700 Added configuration of git remotes to dev container setup (TryGhost#21458) no issue - Added function to Dev Container onCreateCommand to setup git remotes when creating the Dev Container - If `$GHOST_UPSTREAM` is set, it will rename the default `origin` remote to its value - It will also update the remotes for the submodules, otherwise `yarn main` will fail - If `$GHOST_FORK_REMOTE_URL` is set, it will add it as `origin`, or the value of `$GHOST_FORK_REMOTE_NAME` if set. - If `$GHOST_FORCE_SSH` is set to `true`, it will change all remotes URL's to use ssh instead of https commit c299051 Author: Djordje Vlaisavljevic <dzvlais@gmail.com> Date: Tue Oct 29 21:55:30 2024 +0100 Fixed incorrect actor passed from like notifications (TryGhost#21451) ref https://linear.app/ghost/issue/AP-541/incorrect-object-loaded-on-like-notifications - We were passing the wrong `actor` info from `like` notifications. We should be using `activity.object.attributedTo` instead. commit 71fb9f8 Author: Chris Raible <chris@ghost.org> Date: Tue Oct 29 13:03:49 2024 -0700 Converted dev container's onCreateCommand to JavaScript (TryGhost#21457) no issue - The onCreateCommand was previously a bash script, which made it a bit more challenging to read and make changes to it. This commit converts it to JavaScript so it will be easier to make updates to it. commit 2ed00b6 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 14:38:53 2024 -0400 bad in exactly every way, but a start! commit 856dd1f Author: Kevin Ansfield <kevin@lookingsideways.co.uk> Date: Tue Oct 29 17:46:35 2024 +0000 🐛 Fixed "Access Denied" error when accepting staff invite ref https://app.incident.io/ghost/incidents/117 - the authenticate call made as part of signup was missed as part of the update when we adjusted the params for `cookie` authenticator's `authenticate` method in Admin so it could switch behaviour for 2fa - fixed the authenticate call params and updated our mocked `/session` endpoint to check for expected POST data which would have let tests catch this error commit 28a9a43 Author: Michael Barrett <mike@ghost.org> Date: Tue Oct 29 17:07:01 2024 +0000 Prevent replies from being shown on profile page in admin-x-activitypub (TryGhost#21454) refs [AP-543](https://linear.app/ghost/issue/AP-543/posts-on-profile-should-not-include-replies) Filtered the posts on the profile page to only show `Create` activities that are not replies. commit cc2fc1c Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 09:42:39 2024 -0400 more snapshots. commit e66ff34 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 09:31:28 2024 -0400 fix snapshots in places I didn't know we had snapshots. commit 3cc0380 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 09:19:39 2024 -0400 more broken tests commit 8456170 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 09:07:27 2024 -0400 fix broken test commit 253608a Author: Steve Larson <9larsons@gmail.com> Date: Tue Oct 29 07:49:25 2024 -0500 Cover last lines in unit test commit 2fc2c6a Author: Sanne de Vries <sannedv@protonmail.com> Date: Tue Oct 29 13:17:05 2024 +0100 Updated feedback button styling No issue - Removed all mobile feedback button code - Updated styling of feedback buttons to display in a single row on desktop and column on mobile commit 4a8da45 Author: Daniël van der Winden <danielvanderwinden@ghost.org> Date: Tue Oct 29 12:03:43 2024 +0100 Fixed searchbar's X button overlapping with Settings' X button (TryGhost#21449) fixes https://linear.app/ghost/issue/DES-316/adminx-settings-search-overlaps-with-modal-close-x-when-in-mobile-view Regression, solved by removing an overexcited media query. commit 156775b Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 06:46:45 2024 -0400 test tweaks commit 456af29 Author: Sanne de Vries <65487235+sanne-san@users.noreply.github.com> Date: Tue Oct 29 11:44:00 2024 +0100 Fixed avatar initials being broken in comment form (TryGhost#21448) REF PLG-248 commit cc8a36c Author: Djordje Vlaisavljevic <dzvlais@gmail.com> Date: Tue Oct 29 11:26:27 2024 +0100 Fixed articles getting cut off in the drawer (TryGhost#21447) ref https://linear.app/ghost/issue/AP-542/articles-are-cut-off-when-viewed-in-sidebar - We now wait for the content of the iframe to load completely before determining the height needed to display it commit ba30684 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 05:56:08 2024 -0400 and the snap commit fbe7250 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Tue Oct 29 05:53:13 2024 -0400 date localization problem fixed? commit e6df621 Author: Michael Barrett <mike@ghost.org> Date: Tue Oct 29 09:46:43 2024 +0000 Updated ActivityPub collection retrieval to accommodate pagination (TryGhost#21393) refs [AP-526](https://linear.app/ghost/issue/AP-526/implement-pagination-for-fedify-collections) Updated followers, following, outbox and liked collection retrieval to accommodate pagination commit 4b32a3d Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com> Date: Tue Oct 29 15:31:29 2024 +0800 Fixed signup card button height (TryGhost#21446) ref DES-923 commit d6639fd Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 23:41:38 2024 -0400 added a creation date - my mock is too good, and needs one to make the snapshots work! commit f8ef2a1 Author: Fabien 'egg' O'Carroll <fabien@allou.is> Date: Tue Oct 29 03:17:57 2024 +0000 Fixed layout state sync issues (TryGhost#21443) refs https://linear.app/ghost/issue/AP-544 useState was still called twice, we should have pulled that out - but instead passing values down for now commit 4d35d31 Merge: abc4d7b 1c51718 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 23:09:05 2024 -0400 Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost into newsletter-t commit abc4d7b Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 23:09:01 2024 -0400 fix dates... again. commit 1c51718 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Mon Oct 28 22:54:54 2024 -0400 argh, package.json... commit 071cf48 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 22:51:52 2024 -0400 preliminary update of snapshots for translatable buttons commit bde1755 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 22:24:49 2024 -0400 make buttons translatable commit 7922bcd Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 21:58:33 2024 -0400 lint is hard commit 2d29b78 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 21:53:53 2024 -0400 better test commit 6c0adf3 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 21:50:42 2024 -0400 test wrangling commit 6240f25 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 21:18:14 2024 -0400 test fussing commit 869ea0b Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 21:03:43 2024 -0400 e2e test fix? commit 01e5bdb Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 20:21:17 2024 -0400 t fun. commit 0cf65a0 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 20:12:10 2024 -0400 only one failing test? commit d0bf80b Author: Chris Raible <chris@ghost.org> Date: Mon Oct 28 16:14:04 2024 -0700 Added `from` address to Dev Container's auto configuration (TryGhost#21442) refs https://linear.app/ghost/issue/ENG-1686/mail-auto-configuration-doesnt-work - Previously the `mail` configuration that is auto-generated didn't work because the `from` address wasn't being set, and requests were consequently failing due to some Mailgun internal validation. - This change requires the `MAILGUN_FROM_ADDRESS` environment variable to be set for it to automatically configure the `mail` block, and if it is, it adds it as `mail.from`. Now with all three of `MAILGUN_SMTP_AUTH`, `MAILGUN_SMTP_PASS` and `MAILGUN_FROM_ADDRESS` setup, transactional emails work out of the box in the Dev Container. commit c1100c8 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 17:27:02 2024 -0400 try building, probably fail lint. commit 75948c6 Merge: 5581695 2c7de4e Author: Ghost CI <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Oct 28 20:53:37 2024 +0000 Merged v5.98.1 into main commit 2c7de4e Author: Ghost CI <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Oct 28 20:53:35 2024 +0000 v5.98.1 commit 00bd31a Author: Steve Larson <9larsons@gmail.com> Date: Mon Oct 28 09:58:09 2024 -0500 🐛 Fixed malformed `unsubscribe_url` in members api response (TryGhost#21437) no ref commit 2b29812 Author: Sodbileg Gansukh <sodbileg.gansukh@gmail.com> Date: Mon Oct 28 18:36:38 2024 +0800 Fixed banner text color in dark mode (TryGhost#21427) ref DES-908 commit 3afc818 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 15:33:57 2024 -0400 hating importing. commit 49aec51 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 15:13:59 2024 -0400 tweak imports again? commit 35a639a Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 15:03:11 2024 -0400 build error? commit cb401ed Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 14:48:36 2024 -0400 import issues commit d8d5de5 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 14:35:36 2024 -0400 issues with imports? commit d095750 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 13:51:47 2024 -0400 belly button lint? commit d1eabc7 Merge: ea617f4 1774caa Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 13:47:30 2024 -0400 Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost into newsletter-t commit ea617f4 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 13:47:28 2024 -0400 date i18n commit 1774caa Merge: ea627fa 5581695 Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Mon Oct 28 12:55:16 2024 -0400 Merge branch 'main' into newsletter-t commit ea627fa Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 09:32:23 2024 -0400 add a test commit 7f66b14 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 09:19:11 2024 -0400 stray space = failed test :( commit e88c57c Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 09:14:27 2024 -0400 dangit lint commit 8834ef6 Merge: 6ae2844 3c3aa27 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 09:10:20 2024 -0400 Merge branch 'newsletter-t' of https://github.com/cathysarisky/Ghost into newsletter-t commit 6ae2844 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 09:10:10 2024 -0400 ah lint commit 3c3aa27 Merge: 3a7c50f bf714ac Author: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com> Date: Mon Oct 28 09:00:10 2024 -0400 Merge branch 'main' into newsletter-t commit 3a7c50f Author: Cathy Sarisky <catsarisky@gmail.com> Date: Mon Oct 28 08:43:57 2024 -0400 fixed! commit 4960f84 Author: Cathy Sarisky <catsarisky@gmail.com> Date: Sun Oct 27 19:12:47 2024 -0400 almost there! commit 4d60bcb Author: Cathy Sarisky <catsarisky@gmail.com> Date: Sun Oct 27 16:52:37 2024 -0400 initial commit iwth date error
tilak999
pushed a commit
to tilak999/ghost
that referenced
this pull request
Nov 20, 2024
…21442) refs https://linear.app/ghost/issue/ENG-1686/mail-auto-configuration-doesnt-work - Previously the `mail` configuration that is auto-generated didn't work because the `from` address wasn't being set, and requests were consequently failing due to some Mailgun internal validation. - This change requires the `MAILGUN_FROM_ADDRESS` environment variable to be set for it to automatically configure the `mail` block, and if it is, it adds it as `mail.from`. Now with all three of `MAILGUN_SMTP_AUTH`, `MAILGUN_SMTP_PASS` and `MAILGUN_FROM_ADDRESS` setup, transactional emails work out of the box in the Dev Container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://linear.app/ghost/issue/ENG-1686/mail-auto-configuration-doesnt-work
mailconfiguration that is auto-generated didn't work because thefromaddress wasn't being set, and requests were consequently failing due to some Mailgun internal validation.MAILGUN_FROM_ADDRESSenvironment variable to be set for it to automatically configure themailblock, and if it is, it adds it asmail.from. Now with all three ofMAILGUN_SMTP_AUTH,MAILGUN_SMTP_PASSandMAILGUN_FROM_ADDRESSsetup, transactional emails work out of the box in the Dev Container.