Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed archived newsletters visible in Portal when email disabled #21737

Merged
merged 4 commits into from
Dec 16, 2024
Merged

🐛 Fixed archived newsletters visible in Portal when email disabled #21737

merged 4 commits into from
Dec 16, 2024

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented Nov 27, 2024 •
edited
Loading

ref ONC-225

  • Ensures newsletter preferences are hidden in the Portal when email functionality is disabled.
  • Adds conditional logic in NewsletterManagement.js to check for the hasNewslettersEnabled prop.
  • Updates tests in AccountEmailPage.test.js and AccountHomePage.test.js to cover scenarios where newsletters are disabled.
  • Improves user experience by preventing the display of irrelevant settings when email is turned off.

@ronaldlangeveld ronaldlangeveld changed the title Fixed newsletters visible when disabled in Portal 🐛 Fixed archived newsletters is visible in Portal when email is disabled Dec 16, 2024
@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review December 16, 2024 05:42
@ronaldlangeveld ronaldlangeveld changed the title 🐛 Fixed archived newsletters is visible in Portal when email is disabled 🐛 Fixed archived newsletters not to be visible in Portal when email is disabled Dec 16, 2024
@ronaldlangeveld ronaldlangeveld changed the title 🐛 Fixed archived newsletters not to be visible in Portal when email is disabled 🐛 Fixed archived newsletters visible in Portal when email disabled Dec 16, 2024
@ronaldlangeveld ronaldlangeveld merged commit 3233bae into main Dec 16, 2024
18 checks passed
@ronaldlangeveld ronaldlangeveld deleted the fixed-newsletters-not-hidden-portal branch December 16, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ronaldlangeveld