🐛 Fixed tags and authors not fitting in the input field

[dvdwinden]

Input fields for tags and authors in the post sidebar were hard to use; they became scrollable if you added more than one line of either.

This fix addresses that; the input field now grows in size to accommodate for the number of tags or authors you enter.

fixes https://linear.app/ghost/issue/DES-1087/overflow-on-boxes-in-post-settings-too-small, https://linear.app/ghost/issue/DES-1084/tag-field-in-post-settings-menu-is-difficult-to-work-now-with-when

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ghost/admin/app/styles/components/power-select.css

Oops! Something went wrong! :(

ESLint: 8.44.0

Error: Failed to load parser '@babel/eslint-parser' declared in 'ghost/admin/.eslintrc.js': Cannot find module '@babel/eslint-parser'
Require stack:

• /ghost/admin/.eslintrc.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Function.resolve (node:internal/modules/helpers:145:19)
  at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
  at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
  at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
  at _normalizeObjectConfigDataBody.next ()
  at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
  at _normalizeObjectConfigData.next ()
  at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
  at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Walkthrough

This pull request focuses on CSS modifications in two files related to the Ghost admin interface. The changes primarily target the styling of input elements and dropdown components, specifically adjusting the layout, positioning, and sizing of .ember-power-select classes. The modifications aim to improve the visual responsiveness and flexibility of form inputs and dropdown triggers, with specific attention to height, padding, and grid/flex display properties.

Changes

File	Change Summary
ghost/admin/app/styles/components/power-select.css	- Updated .ember-power-select-status-icon positioning - Changed top from -4px to 13px - Added position: absolute;
ghost/admin/app/styles/patterns/forms.css	- Modified .gh-input-x height to be dynamic - Updated .ember-power-select-multiple-trigger padding and layout - Added new classes .ember-power-select-multiple-options and .ember-power-select-trigger-multiple-input for improved dropdown styling

Possibly related PRs

• Fixed reading progress indicator for very short articles #22036: Changes to ArticleModal.tsx component involving loading state and reading progress tracking, which shares a similar focus on component presentation and visual refinement

Suggested reviewers

• mike182uk

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

ghost/admin/app/styles/patterns/forms.css (1)

325-331: Consider increasing the minimum width for better usability.

While the current styles work well, consider increasing min-width from 60px to something larger (e.g., 120px) to provide more comfortable space for typing longer tag/author names.

 .ember-power-select-trigger-multiple-input {
     margin: 2px;
     padding: 0;
     border: 0;
     background: none;
-    min-width: 60px;
+    min-width: 120px;
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c2e62d and ccde576.

📒 Files selected for processing (2)

• ghost/admin/app/styles/components/power-select.css (1 hunks)
• ghost/admin/app/styles/patterns/forms.css (2 hunks)

🔇 Additional comments (5)

ghost/admin/app/styles/components/power-select.css (1)

312-313: LGTM: Status icon positioning aligns with grid layout.

The absolute positioning of the status icon ensures it remains properly aligned when the input field expands to accommodate multiple tags/authors.

ghost/admin/app/styles/patterns/forms.css (4)

285-286: LGTM: Input field now expands properly.

The change from fixed height to min-height with auto height allows the input field to grow vertically while maintaining a minimum size of 38px, effectively addressing the issue of tags and authors not fitting in the input field.

---

309-314: LGTM: Grid layout improves input field structure.

The grid layout with relative positioning creates a robust structure for the input field:

• 1fr column for content ensures maximum space for tags/authors
• 24px column properly accommodates the dropdown icon
• Relative positioning provides the correct context for the absolutely positioned status icon

---

316-323: LGTM: Flexbox layout ensures proper tag/author spacing.

The flexbox layout with wrap and gap provides optimal spacing and alignment for multiple tags/authors:

• flex-wrap allows tags to flow to the next line when needed
• gap: 4px ensures consistent spacing between tags
• align-items: center keeps tags vertically centered

---

333-336: LGTM: Status icon alignment complements grid layout.

The margin and transform changes ensure the dropdown icon remains properly centered in its designated grid column.