Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block content array must be concated with newline, not stringified #153

Closed
EriksRemess opened this issue Jan 9, 2019 · 2 comments
Closed

Block content array must be concated with newline, not stringified #153

EriksRemess opened this issue Jan 9, 2019 · 2 comments
Assignees
@jtwebman
Labels
bug

Comments

@EriksRemess
Copy link
Contributor

block stringifies array of all referenced to it contentFor contents. That adds a comma between them. By handlebar spec and by previous behaviour of this Node module, array of assigned block items should be concated with newlines.
I have created pull request that fixes this issue:
#152
@jtwebman
Copy link
Collaborator

Thank you for the PR. Sorry this was missed, any chance you can also add a test for this so it isn't missed in the future?

@jtwebman jtwebman added the bug label Jan 10, 2019
@jtwebman
Copy link
Collaborator

#152 was merged and release in 2.0.1, closing the ticket.

@jtwebman jtwebman self-assigned this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtwebman jtwebman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EriksRemess @jtwebman